✅ Deploy Preview for jakartaee-specifications ready!

Name	Link
🔨 Latest commit	33d4b59
🔍 Latest deploy log	https://app.netlify.com/sites/jakartaee-specifications/deploys/665fcd1c6e5f7d00085540e0
😎 Deploy Preview	https://deploy-preview-738--jakartaee-specifications.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Hello all,
the EMO is trying to avoid duplication of release records, so we will be providing our feedback and comments related to this release directly here.

EMO REVIEW CHECKLIST

EDP Review status: Completed

EMO review checklist

PMI record: URL

EF Specification Process

• Spec Committee Ballot completed

Intellectual Property Management

• All project code has copyright and license headers correctly applied. ** EMO will scan the code at their discretion **
• All distributed third-party content has been vetted by the IP Due Diligence process (i.e., IP Log has been approved)

Open Source Rules of Engagement

• PMC approval on the mailing list

General:

• Project is operating within the mission and scope defined in its top-level project’s charter
• Project is operating within the bounds of its own scope
• Project is operating in an open and transparent manner
• Overall the project is operating according to the Eclipse Development Process.

Things to check:

• Communication channels advertised
• Advertised communication channels used
• Committers are responding to questions
• Committers are responding to issues
• Committers are responding to pull/merge/review requests

Branding and Trademarks
The following applies when the project has a custom website.
To the best of our knowledge:

• Project content correctly uses Eclipse Foundation trademarks
• Project content (code and documentation) does not violate trademarks owned by other organizations

Things to check:

• Project website uses the project's formal name in first and all prominent references
• Project website includes a trademark attribution statement
• Project website footers contain all necessary elements

Legal Documentation
Required files:

• License files in all repository roots
• README
• CONTRIBUTING (or equivalent)

Recommended files:

• NOTICES or equivalent (you can use the Legal Documentation generator available under committer tools)
• CODE_OF_CONDUCT
• SECURITY

See examples for Security file and Code of Conduct.

Required elements:

• ECA is referenced/described

Recommended elements:

• Build instructions provided
• Security policy is described

Metadata (PMI)

• The formal name, e.g. "Eclipse Foo™", is used in the project title
• The formal name including appropriate marks (e.g, "™") is used in the first mention in the text of the project description, and scope
• The project description starts with a single paragraph that can serve as an executive summary
• Source code repository references are up-to-date
• Download links and information are up-to-date (see EF handbook for more information on how-to do this)
• Communication channels listed in the PMI (i.e. public mailing list, forums, etc.)

Mentor Spec Review Checklist

1. Spec PR

• PR uses template
• Directory of form {spec}/x.y
• PDF of form jakarta-{spec}-spec-x.y.pdf ("-spec" preferred but not required)
• HTML of form jakarta-{spec}-spec-x.y.html ("-spec" preferred but not required)
• Index page {spec}/x.y/_index.md following template
• Index page {spec}/_index.md following template
• No other files (e.g., no jakarta_ee_logo_schooner_color_stacked_default.png)
• Staging repository link of the form https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/{spec}/jakarta.{spec}-api/x.y.z/
• EFTL TCK link of the form http://download.eclipse.org/.../+.zip
• Compatibility certification link of the form https://github.com/eclipse-ee4j/{project}/#{issue}
• (Optional) Second PR for just apidocs

2. _index.md

• Link to project release plan of the form https://projects.eclipse.org/projects/ee4j.{spec}/releases/x.y/plan
• Link to spec pdf
• Link to spec html
• Link to apidocs
• Link to final TCK download zip file of the form https://download.eclipse.org/jakartaee/{spec}/x.y/*{spec}-tck-x.y.z.zip (The folder path is required, the file name pattern is preferred.)
• Link to API jar file of the form https://search.maven.org/artifact/jakarta.{spec}/jakarta.{spec}-api/x.y.z/jar
• Name of and link to at least one Compatible Implementation
• Review summary statement to ensure it has been updated to reflect the work accomplished and does not contain proposal statements as might be found in Plan Review statement.

3. javadocs

• Footer contains Eclipse copyright and link to license
• ESFL license is included, usually as doc-files/speclicense.html
• no META-INF directory in PR
• javadocs-jar artifact matches apidocs (optional for this release)

4. Spec PDF

• Correct spec title
• Version number of the form x.y, not x.y.z
• Correct Eclipse copyright line
• No DRAFT or SNAPSHOT
• Correct Logo

5. Spec HTML

• Same as PDF

6. TCK zip file

• README file (optional for this release)
• EFTL license file, preferably named LICENSE.md
• User's Guide (or equivalent documentation)
• How to test the Compatible Implementation(s) listed in _index.md above with the TCK (may be in UG)

7. TCK User's Guide (or equivalent documentation)

• Software requirements listed
• Installation and configuration described
• How to run tests
• Where to file challenges

8. Compatibility certification request

• Request follows template
• SHA-256 fingerprint matches staged TCK zip file
• Request issue has certification label.

9. TCK results summary

• Page is hosted by Compatible Implementation project
• Includes all information from certification request
• Summary includes number of tests passed, failed, errors
• SHA-256 fingerprint matches staged TCK zip file on cert request

10. If a Release Review is required, the specification project team contacts the EMO to initiate the review by sending an email to [email protected].
    (A Release Review is not required if the current release is a Service Release based on a previously successful Major or Minor
    release as indicated by a release record on the project's Releases page, e.g., the Jakarta Servlet releases page.)

    • The specification project team requests approval by sending an email to the EMO (with cc to the PMC) that contains a link to this PR and a request to the PMC for approval.

11. Update Jakarta EE API jar

• Update the Jakarta EE API jar by submitting a PR to the jakartaee-api project that updates the version number of your API jar file.

@kazumura CCR has been added

@arjantijms
Thanks for PR.

The followings are missing in this PR. Please add them.

• Jsdoc
• Renderkitdoc
• VDLDoc

The followings are missing in this PR. Please add them.

Thanks, it is done!

Hi, the _index.md should be updated to reflect the changes for Faces 4.1.

We should call out the changes from the Faces 4.1 Changelog.

These are Faces 5.0 changes that should be removed:

1. Make SelectItem#value generic faces#206 (Make SelectItem#value generic Component: Components/Renderers)
2. Clarify EL / CDI integration: implicit object or CDI producer for artifacts without required inject point support (request, session, component, cc) faces#1564 looks to be mentioned: Re-add #{request} in CDI mode
3. Clarify EL / CDI integration: implicit object or CDI producer for artifacts without required inject point support (request, session, component, cc) faces#1564 looks to be mentioned: Re-add #{request} in CDI mode

Missing Deprecation:

1. Missing Full State Saving Deprecation in the deprecations list: Faces 4.1: Deprecate full state saving (FSS) faces#1829

Other:

1. I don't think there is a need to call out: Remove unused PreDestroyCustomScopeEvent and PostConstructCustomScopeEventAdd in both the new features and removals.

Hi, the _index.md should be updated to reflect the changes for Faces 4.1.

Thanks, can you verify the updated index?

Hi @arjantijms

We should remove the following as they point to Faces 5.0 work:

1. "importConstants should be allowed everywhere, not only in f:metadata" as that is in Faces 5.0: importConstants should be allowed everywhere, not only in f:metadata faces#1466
2. "Enhance UIInput events with HTML5 like oninput" as that is also Faces 5.0: Enhance UIInput events with HTML5 like oninput faces#1507
3. Setting/overriding components default value -> Setting/overriding components default value faces#1602

Also I think removing "<f:ajax> execute="@this" and render="@this" does not behave as expected when nested in composite component" would be good since that looks like it was for Faces 4.0: jakartaee/faces#1567

Would be good to add:

Add UUIDConverter -> jakartaee/faces#1819
Add ExternalContext.setResponseContentLengthLong -> jakartaee/faces#1764
Add rowStatePreserved property to UIRepeat, exactly the same as UIData -> jakartaee/faces#1263
Spec: jakarta.faces.FACELETS_REFRESH_PERIOD default when ProjectStage is Development -> jakartaee/faces#1821
FacesMessage: implement equals(), hashcode(), toString() -> jakartaee/faces#1823

@arjantijms
Please look into @pnicolucci comment at "#738 (comment)" .

Please look into @pnicolucci comment at "#738 (comment)" .

I just did, thanks! @pnicolucci can you do the final check?

@arjantijms this looks good! My only minor comment is that the UUID entry points to an issue but nothing else does. So for consistency, we could remove the issue reference, or add an issue for each item.

On ballot completion, the specification committee mentor:

• adds this final checklist to the main PR.
• adds the approved label to the PRs, and sends out the Ballot Summary per this template to the public Jakarta EE Specification Committee email list
• calculates the staged EFTL TCK signature and promotes it to the committee download area
  using the https://ci.eclipse.org/jakartaee-spec-committee/job/promote-release/ job. Manually editing the jenkins Build Information will help identify the build (ie. Mail 2.0 or CDI 3.0).
• merges the specification (and apidocs) PRs, ensuring the "date:" field in the _index.md file has an appropriate value to allow publishing.
• updates the specification page with the ballot results. This is normally done via a separate PR that should be reviewed, approved, and merged.
• notifies the EMO of the ballot results by email to [email protected]. Just forward the ballot summary note sent earlier to the public Spec Committee email list.
• creates an issue in the specification project that includes the following checklist for the specification project team: Finalize the Jakarta Faces 4.1 Release faces#1930